Skip to content

MEDIUM CONTROLLERS: Contributor Post Tests#314

Merged
glhays merged 15 commits into
The-Standard-Organization:mainfrom
SlimAhmad:users/slimahmad/controller/contributor-Post
May 30, 2025
Merged

MEDIUM CONTROLLERS: Contributor Post Tests#314
glhays merged 15 commits into
The-Standard-Organization:mainfrom
SlimAhmad:users/slimahmad/controller/contributor-Post

Conversation

@SlimAhmad

Copy link
Copy Markdown
Collaborator

Closes #313

@SlimAhmad

Copy link
Copy Markdown
Collaborator Author

image

@SlimAhmad SlimAhmad marked this pull request as draft March 27, 2025 16:26
@SlimAhmad SlimAhmad changed the title CONTROLLERS: Contribor Controller - Post CONTROLLERS: Contributor Controller - Post Mar 27, 2025
@glhays glhays changed the title CONTROLLERS: Contributor Controller - Post MEDIUM CONTROLLERS: Contributor Post Tests Mar 27, 2025
@glhays

glhays commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

@SlimAhmad why are your commits not verified anymore. Can you check it out please.

@glhays

glhays commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

@SlimAhmad I noticed your Branching is using "/" sb; users/slimahmad/mediumcontrollers-contributor-post-tests
FYI, and please double check your work for the obvious line breaks, formatting issues, etc. B4 requesting review. It gets tiresome pointing out the same ole same ole.

@SlimAhmad

SlimAhmad commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator Author

@glhays sure no problem, I'll do

@SlimAhmad I noticed your Branching is using "/" sb; users/slimahmad/mediumcontrollers-contributor-post-tests FYI, and please double check your work for the obvious line breaks, formatting issues, etc. B4 requesting review. It gets tiresome pointing out the same ole same ole.

@glhays i don't think i have any branch as mediumcontrollers i'll check. sure I'll work on the formatting issues sorry

@SlimAhmad

Copy link
Copy Markdown
Collaborator Author

@SlimAhmad why are your commits not verified anymore. Can you check it out please.

Okay

@glhays

glhays commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

@glhays sure no problem, I'll do

@SlimAhmad I noticed your Branching is using "/" sb; users/slimahmad/mediumcontrollers-contributor-post-tests FYI, and please double check your work for the obvious line breaks, formatting issues, etc. B4 requesting review. It gets tiresome pointing out the same ole same ole.

@glhays i don't think i have any branch as mediumcontrollers i'll check. sure I'll work on the formatting issues sorry

No you don't I just created the labels, something to implement going forward. The new pointing is going to be based on MMM minor medium and major like here you could do a major controller that encompasses all Contributor tests as MAJOR CONTOLLERS: Contributor Tests
Just saying this branch should be.

@SlimAhmad

Copy link
Copy Markdown
Collaborator Author

@glhays sure no problem, I'll do

@SlimAhmad I noticed your Branching is using "/" sb; users/slimahmad/mediumcontrollers-contributor-post-tests FYI, and please double check your work for the obvious line breaks, formatting issues, etc. B4 requesting review. It gets tiresome pointing out the same ole same ole.

@glhays i don't think i have any branch as mediumcontrollers i'll check. sure I'll work on the formatting issues sorry

No you don't I just created the labels, something to implement going forward. The new pointing is going to be based on MMM minor medium and major like here you could do a major controller that encompasses all Contributor tests as MAJOR CONTOLLERS: Contributor Tests Just saying this branch should be.

okay noted

@SlimAhmad SlimAhmad self-assigned this Apr 30, 2025
@SlimAhmad SlimAhmad requested review from aosunlana, cjdutoit and glhays and removed request for cjdutoit April 30, 2025 14:16
@SlimAhmad SlimAhmad marked this pull request as ready for review April 30, 2025 14:19
@glhays glhays marked this pull request as draft April 30, 2025 22:38
@glhays

glhays commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

@SlimAhmad There is no foundation for a FK exception for this controller type. From what I can see at least. So not ready for review.

@glhays

glhays commented May 28, 2025

Copy link
Copy Markdown
Collaborator

@SlimAhmad resolve conflicts please

@SlimAhmad

Copy link
Copy Markdown
Collaborator Author

@glhays done

@glhays glhays marked this pull request as ready for review May 30, 2025 20:53
@glhays glhays merged commit c0a83f7 into The-Standard-Organization:main May 30, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MEDIUM CONTROLLERS: Contributor Post Tests

2 participants